Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📝 Docs #10

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

📝 Docs #10

wants to merge 1 commit into from
+15 −132

Conversation

ThatXliner
Copy link
Member

No description provided.

realjoshuau
realjoshuau requested changes Nov 18, 2023
View reviewed changes
.gitignore
@@ -59,3 +59,5 @@ xcuserdata

# VSCode
.history/

.env*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I needed it, but then I forgot that this repository is private anyway.

still not a good practice to commit keys into repos. I guess we can make exceptions for .env.example

README.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, you should keep the old README.md as a reference for build tools / CI / etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realjoshuau realjoshuau realjoshuau requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThatXliner @realjoshuau